Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: no floating promises #756

Merged
merged 1 commit into from
Sep 11, 2023
Merged

feat: no floating promises #756

merged 1 commit into from
Sep 11, 2023

Conversation

naseemkullah
Copy link
Contributor

closes #546

@naseemkullah naseemkullah changed the title feat: nof-loating-promises feat: no floating promises Jan 14, 2023
@naseemkullah
Copy link
Contributor Author

someone please take a look please

@danielbankhead danielbankhead self-assigned this Aug 29, 2023
@danielbankhead
Copy link
Collaborator

@naseemkullah - I'll discuss this with the team and get back to you

@danielbankhead
Copy link
Collaborator

Hey @naseemkullah, the PR looks great - thanks for the contribution. To not immediately break anyone do you mind changing the rule to warn rather than error? I can create a follow-up to change it to error in the next major release.

@naseemkullah
Copy link
Contributor Author

Thanks @danielbankhead - certainly, changed to warn for now and we can change it to error upon next major release if all's well.

@naseemkullah
feat: no-floating-promises
1aae8e8 
closes google#546

Signed-off-by: Naseem Ullah <[email protected]>
@danielbankhead danielbankhead enabled auto-merge (squash) September 11, 2023 18:30
@danielbankhead danielbankhead merged commit c93e733 into google:main Sep 11, 2023
8 checks passed
@release-please release-please bot mentioned this pull request Sep 11, 2023
Merged
@danielbankhead danielbankhead mentioned this pull request Sep 11, 2023
Closed
danielbankhead added a commit that referenced this pull request Oct 3, 2023
@danielbankhead
Revert "feat: no-floating-promises (#756)"
a334d8c 
This reverts commit c93e733.
danielbankhead added a commit that referenced this pull request Oct 3, 2023
@danielbankhead
Revert "feat: no-floating-promises (#756)" (#808)
44de7f7 
This reverts commit c93e733.
@WontonSam WontonSam mentioned this pull request Jul 16, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 17, 2024
Open
@WontonSam WontonSam mentioned this pull request Jul 17, 2024
Open
This was referenced Sep 8, 2024
Open
Open
This was referenced Sep 16, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees

@danielbankhead danielbankhead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add @typescript-eslint/no-floating-promises to default lint rules
2 participants
@naseemkullah @danielbankhead