build: use github actions #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
========================================
Coverage ? 96.4%
========================================
Files ? 6
Lines ? 1139
Branches ? 153
========================================
Hits ? 1098
Misses ? 41
Partials ? 0Continue to review full report at Codecov.
|
bcoe
approved these changes
Feb 4, 2020
bcoe
reviewed
Feb 4, 2020
| - run: npm run codecov | ||
| - uses: codecov/codecov-action@v1 | ||
| with: | ||
| token: ${{ secrets.CODECOV_TOKEN }} |
There was a problem hiding this comment.
I noticed on wombat dressing room permission issues on the upload step of codecov, we should check the logs for the action when this runs.
There was a problem hiding this comment.
I had to manually set the CODECOV_TOKEN, which is something we'd need to figure out if looking at this broadly for client libs. Other than that - it works!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.