Made JsonArray implement the List interface. #683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swankjesse @JakeWharton Is this a good idea (to implement List instead of Iterable for JsonArray)? Bloats the API a little bit, but useful nonetheless. |
|
It isn't a binary-compatible change. |
|
Don't forget equals(). |
|
It don't feel strongly either way. If we make this change we will need to figure out the binary compatibility problem. Also if we make this change we should change JsonObject to implement Map for symmetry. |
| @@ -30,7 +32,7 @@ | |||
| * @author Inderjeet Singh | |||
| * @author Joel Leitch | |||
| */ | |||
| public final class JsonArray extends JsonElement implements Iterable<JsonElement> { | |||
| public final class JsonArray extends JsonElement implements List<JsonElement> { | |||
There was a problem hiding this comment.
You'll also want the RandomAccess marker interface.
|
I agree we should keep binary compatibility. Closing the pull request. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.