-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Switch to using central-publishing-maven-plugin. #2900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cpovirk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray, and thank you!
| <extensions>true</extensions> | ||
| <configuration> | ||
| <skip>${gson.isInternalModule}</skip> | ||
| <publishingServerId>central</publishingServerId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I eventually concluded that we did not need this, and I've successfully released projects in that state.
But if you want to merge as-is because you know that things are working, I'm fine with that :)
| <version>0.8.0</version> | ||
| <extensions>true</extensions> | ||
| <configuration> | ||
| <skip>${gson.isInternalModule}</skip> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that we could now remove the places where we set isInternalModule, which doesn't appear to have been used from places other than here.
But if you want to merge as-is because you know that things are working, I'm fine with that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's exactly right. I want to get a thing in that works and is at least moderately clean. We can tweak later.
|
@eamonnmcmanus, for the release notes do you want to explicitly mention that this should fix the Eclipse and VS Code module declaration issue? (#2679) |
Thanks, I was trying to find that but couldn't in the moment. Do you want to suggest a wording for this note? (Or if you are able to edit them directly that would also be fine.) |
|
Maybe something like this (but feel free to change it as you like):
Markdown source: - Improved packaging of JPMS module declaration in Gson jar\
This fixes an issue where Eclipse and VS Code users could not refer to the Gson module name `com.google.gson`. See issue https://github.com/google/gson/issues/2679.(I don't have permissions to edit the release notes myself.) |
Thanks! Updated. |
|
Thanks! I have created #2902 to try simplifying the release configuration a bit (and updating the Release Process guide). If you have time the next days or weeks please let me know what you think. |
…ip ci] Bumps [com.google.code.gson:gson](https://github.com/google/gson) from 2.13.1 to 2.13.2. Release notes *Sourced from [com.google.code.gson:gson's releases](https://github.com/google/gson/releases).* > Gson 2.13.2 > ----------- > > The main changes in this release are just newer dependencies. > > What's Changed > -------------- > > * Improved packaging of JPMS module declaration in Gson jar > This fixes an issue where Eclipse and VS Code users could not refer to the Gson module name `com.google.gson`. See issue [google/gson#2679](https://github.com/google/gson/issues/2679). > * Remove internal class `GsonPreconditions` by [`@Marcono1234`](https://github.com/Marcono1234) in [google/gson#2879](https://github.com/google/gson/pull/2879) > * Switch to using central-publishing-maven-plugin by [`@eamonnmcmanus`](https://github.com/eamonnmcmanus) in [google/gson#2900](https://github.com/google/gson/pull/2900) > > New Contributors > ---------------- > > * [`@MukjepScarlet`](https://github.com/MukjepScarlet) made their first contribution in [google/gson#2852](https://github.com/google/gson/pull/2852) > * [`@ChrisCraik`](https://github.com/ChrisCraik) made their first contribution in [google/gson#2856](https://github.com/google/gson/pull/2856) > > **Full Changelog**: <google/gson@gson-parent-2.13.1...gson-parent-2.13.2> Commits * [`686fad7`](google/gson@686fad7) [maven-release-plugin] prepare release gson-parent-2.13.2 * [`c2d252a`](google/gson@c2d252a) Switch to using central-publishing-maven-plugin. ([#2900](https://github.com/google/gson/issues/2900)) * [`69cb755`](google/gson@69cb755) Bump the github-actions group with 5 updates ([#2894](https://github.com/google/gson/issues/2894)) * [`ea552c2`](google/gson@ea552c2) Bump the maven group across 1 directory with 3 updates ([#2898](https://github.com/google/gson/issues/2898)) * [`fdc616d`](google/gson@fdc616d) Set top-level permissions for CodeQL workflow ([#2889](https://github.com/google/gson/issues/2889)) * [`9334715`](google/gson@9334715) Create scorecard.yml ([#2888](https://github.com/google/gson/issues/2888)) * [`f7de5c2`](google/gson@f7de5c2) Bump the maven group with 8 updates ([#2885](https://github.com/google/gson/issues/2885)) * [`8c23cd3`](google/gson@8c23cd3) Update sources to satisfy a new Error Prone check. ([#2887](https://github.com/google/gson/issues/2887)) * [`5eab3ed`](google/gson@5eab3ed) Bump the github-actions group with 2 updates ([#2886](https://github.com/google/gson/issues/2886)) * [`5f5c200`](google/gson@5f5c200) Bump the maven group across 1 directory with 10 updates ([#2872](https://github.com/google/gson/issues/2872)) * Additional commits viewable in [compare view](google/gson@gson-parent-2.13.1...gson-parent-2.13.2) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
I tested this by making a gson-parent-2.13.2 release, which however I dropped rather than publishing it. I intend to make a full release based on this change, once it is in the main branch.
There is a rather verbose incantation repeated in every module other than
gsonandgson-parent, to exclude those other modules from publication. There is probably a simpler way to do this, with profiles, but for now I'm going with simplicity.Fixes #2892.