Skip to content

Conversation

@eamonnmcmanus
Copy link
Member

Suggested by Google's internal GitHub Security Recommendations.

Suggested by Google's internal GitHub Security Recommendations.
@eamonnmcmanus eamonnmcmanus requested a review from cpovirk August 13, 2025 18:16
Copy link
Member

@cpovirk cpovirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you might already have surmised, this new file should be covered by your existing Dependabot setup for GitHub Actions, which matches Guava's setup, which has successfully led to PRs like https://github.com/google/guava/pull/7912/files.

# Commenting out will disable upload of results to your repo's Code Scanning dashboard
- name: "Upload to code-scanning"
github/codeql-action/upload-sarif@51f77329afa6477de8c49fc9c7046c15b9a4e79d # v3.29.5
with:

Check notice

Code scanning / CodeQL

Syntax error Note

could not find expected ':'
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fixed by latest commit.

@Marcono1234
Copy link
Contributor

There is also an old PR (#2353) for adding scorecard.yml, which is probably obsolete now.

@eamonnmcmanus
Copy link
Member Author

There is also an old PR (#2353) for adding scorecard.yml, which is probably obsolete now.

That's funny! I have zero recollection of that, even though I apparently created it.

@eamonnmcmanus eamonnmcmanus merged commit 9334715 into main Aug 13, 2025
19 checks passed
@eamonnmcmanus eamonnmcmanus deleted the eamonnmcmanus-patch-1 branch August 13, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants