Modification in test cases

[elevne]

Purpose

Simplifying JUnit4 test cases

Description

I thought that when checking only one exception to be thrown on a test case, using @test annotation's "expected" might be very clear.

Checklist

• New code follows the Google Java Style Guide
• If necessary, new public API validates arguments, for example rejects null
• New public API has Javadoc
  • Javadoc uses @since $next-version$
    ($next-version$ is a special placeholder which is automatically replaced during release)
• If necessary, new unit tests have been added
  • Assertions in unit tests use Truth, see existing tests
  • No JUnit 3 features are used (such as extending class TestCase)
  • If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
• mvn clean verify javadoc:jar passes without errors

[eamonnmcmanus]

Thanks for this! We're already using assertThrows in other tests, and I think that would be a better rewrite if you are up for it. With assertThrows we can surround the exact code where the exception is expected, and we can make further assertions about the caught exception.

[elevne]

Thank you for your comment! I've modified some test cases using assertThrows method where it could be much more simplified.

[Marcono1234]

Thanks for these changes! They really make the code more concise and less error-prone than the try { ... fail(); } catch (...) {}.

There are a few cases where the indentation does not match the previous formatting, respectively the Google Style Guide I think. And also some other minor things, see comments below.

If you want to include them, you can do so directly from the GitHub UI if you want.

I hope these changes are also what Éamonn would appreciate.

[elevne]

Thanks for these changes! They really make the code more concise and less error-prone than the try { ... fail(); } catch (...) {}.

There are a few cases where the indentation does not match the previous formatting, respectively the Google Style Guide I think. And also some other minor things, see comments below.

If you want to include them, you can do so directly from the GitHub UI if you want.

I hope these changes are also what Éamonn would appreciate.

I've checked them all. Thank you! It looks much better

[eamonnmcmanus]

Thanks, @elevne and @Marcono1234, this is great!