Fix incorrect inherited URLs in pom.xml
#2351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes incorrect inherited URLs in the
pom.xml
, mainly in the one of thegson
Maven moduleDescription
Previously Maven appended the artifact ID of the modules which lead for example for the
gson
module to the incorrect URL https://github.com/google/gson/gson (note the extra/gson
at the end). This could be seen for example withmvn help:effective-pom
:Other situations where this might have been visible are when using plugins to generate a summary of dependencies of a project and probably also the Sonatype Maven Central browser (see "Project URL" on the right).
This pull request uses the attributes described here to disable appending the artifact ID of the modules. With these changes the output of
mvn help:effective-pom
looks correct:See also the related Guava issue: google/guava#5618
Checklist
null
@since $next-version$
(
$next-version$
is a special placeholder which is automatically replaced during release)TestCase
)mvn clean verify javadoc:jar
passes without errors