Improve exception message for duplicate field names #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marcono1234
force-pushed
the
marcono1234/duplicate-fields-exception-improvements
branch
from
cb60f01 to
4b2ee88
Compare
Marcono1234
commented
Dec 3, 2022
| @@ -310,14 +310,16 @@ private Map<String, BoundField> getBoundFields(Gson context, TypeToken<?> type, | |||
|
|
|||
| static abstract class BoundField { | |||
| final String name; | |||
| final Field field; | |||
There was a problem hiding this comment.
As side note: Most likely BoundField (or rather its anonymous subclass) already had an implicit Field field since it captured the Field from the enclosing scope:
|
This looks great, thanks! |
Marcono1234
deleted the
marcono1234/duplicate-fields-exception-improvements
branch
tibor-universe
pushed a commit
to getuniverse/gson
that referenced
this pull request
Jan 20, 2023
(cherry picked from commit 6c27553)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully makes it easier to troubleshoot this issue, especially when there is a conflict between
@SerializedNameand an inherited field, or when users depend on Java or Android platform types. In the latter case it will be easier as external person to spot the underlying cause of the issue (i.e. serializing third-party types).