Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the version regex in GsonVersionDiagnosticsTest. #2228

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

eamonnmcmanus
Copy link
Member

Before we can release 2.10 we must support two-digit components. Additionally, there's no reason to require a patch number (2.10.0 rather than 2.10).

Before we can release 2.10 we must support two-digit components.
Additionally, there's no reason to require a patch number (2.10.0 rather than 2.10).
@eamonnmcmanus eamonnmcmanus merged commit 4705518 into google:master Oct 25, 2022
@eamonnmcmanus eamonnmcmanus deleted the versioning branch October 25, 2022 00:47
@Marcono1234
Copy link
Collaborator

Marcono1234 commented Oct 25, 2022

If we were strictly following Semantic Versioning then the patch version is required:

A normal version number MUST take the form X.Y.Z where X, Y, and Z are non-negative integers, and MUST NOT contain leading zeroes.

Though I am not sure if that matters much. Also thanks a lot for creating the release!

Edit: And omitting 0 as patch version seems to match Guava's versioning scheme.

@eamonnmcmanus
Copy link
Member Author

Hmm, yes, starting with 2.8.0 in 2016 we've always included the trailing .0, so it was a mistake to have this release be 2.10 rather than 2.10.0. I think I'll undo that part of this PR and add a comment.

@eamonnmcmanus
Copy link
Member Author

Sent #2237 to fix the test and prepare for following the SemVer spec strictly again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants