Add a currently-failing test for Java records and @Ignore it.
#2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also do the Maven gymastics required to ensure that this test only runs on Java versions ≥17. (It would also work on Java 16, but 17 is all we have in the CI.) Fix some compilation problems I saw when running locally, which for some reason don't show up in the CI.
We may fix these later. (Every test will need an explicit constructor!)
Marcono1234
reviewed
Sep 27, 2022
gson/src/test/java/com/google/gson/functional/ReflectionAccessFilterTest.java
Show resolved
Hide resolved
gson/src/test/java/com/google/gson/functional/ReflectionAccessFilterTest.java
Outdated
Show resolved
Hide resolved
…stRelease. Use `assumeNotNull` rather than an if-statement.
Marcono1234
reviewed
Sep 27, 2022
|
I think this is close enough now. Thanks for the feedback, @Marcono1234! We can tweak further as needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also do the Maven gymastics required to ensure that this test only compiles on Java versions ≥17. (It would also work on Java 16, but 17 is all we have in the CI.)
Fix some compilation problems I saw when running locally, which for some reason don't show up in the CI.