Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect HTML headings in Javadoc #2200

Merged
merged 1 commit into from
Sep 25, 2022

Conversation

Marcono1234
Copy link
Collaborator

Follow-up for #2198

It looks like in that pull request only the first incorrect heading was updated, but headings which should be at the same level were not updated, causing them to become sub-headings.

@Marcono1234 Marcono1234 force-pushed the marcono1234/html-headings branch from ef02584 to 82c0933 Compare September 24, 2022 22:43
@Marcono1234 Marcono1234 changed the title Fix incorrect HTML headings Fix incorrect HTML headings in Javadoc Sep 24, 2022
@@ -22,7 +22,8 @@
* Creates type adapters for set of related types. Type adapter factories are
* most useful when several types share similar structure in their JSON form.
*
* <h2>Example: Converting enums to lowercase</h2>
* <h2>Examples</h2>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added a new parent heading here to group the examples a bit, I hope that is fine.

@eamonnmcmanus
Copy link
Member

Thanks, that looks great!

@eamonnmcmanus eamonnmcmanus merged commit 2591ede into google:master Sep 25, 2022
@Marcono1234 Marcono1234 deleted the marcono1234/html-headings branch September 25, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants