-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change target Java version to 7 #2043
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,8 +4,8 @@ apply plugin: 'maven' | |
group = 'com.google.code.gson' | ||
version = '2.8.6-SNAPSHOT' | ||
|
||
sourceCompatibility = 1.6 | ||
targetCompatibility = 1.6 | ||
sourceCompatibility = 1.7 | ||
targetCompatibility = 1.7 | ||
Comment on lines
-7
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Probably does not matter because the Gradle build is outdated anyway, see #1896. |
||
|
||
sourceSets.main.java.exclude("**/module-info.java") | ||
dependencies { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
/** | ||
* This package provides classes for processing JSON in an efficient streaming way. | ||
*/ | ||
package com.google.gson.stream; |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -161,7 +161,7 @@ public void testJavaSerialization() throws IOException, ClassNotFoundException { | |
} | ||
|
||
@SafeVarargs | ||
private <T> void assertIterationOrder(Iterable<T> actual, T... expected) { | ||
private final <T> void assertIterationOrder(Iterable<T> actual, T... expected) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interestingly when changing the version to Java 7 this caused a build failure (due to private methods not supporting |
||
ArrayList<T> actualList = new ArrayList<T>(); | ||
for (T t : actual) { | ||
actualList.add(t); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was an oversight by me; all other modules are using the folder name (instead of the artifact ID).