Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RuntimeTypeAdapterFactory depending on internal Streams class #1959

Merged
merged 3 commits into from
Sep 18, 2021
Merged

Fix RuntimeTypeAdapterFactory depending on internal Streams class #1959

merged 3 commits into from
Sep 18, 2021

Conversation

Marcono1234
Copy link
Collaborator

Fixes #1931

Additionally makes gson-extras a Maven module of gson-parent and cleans up its POM.
Deploying for gson-extras is disabled, hopefully this is respected by the Maven Release Plugin.

@google-cla google-cla bot added the cla: yes label Sep 11, 2021
@Marcono1234 Marcono1234 mentioned this pull request Sep 11, 2021
Closed
@Marcono1234 Marcono1234 force-pushed the marcono1234/RuntimeTypeAdapterFactory-no-internal-dependencies branch from bb6ce33 to 097e196 Compare September 11, 2021 04:22
eamonnmcmanus
eamonnmcmanus requested changes Sep 13, 2021
View reviewed changes
Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I guess we'll see whether the deploy configuration works the next time we release.

extras/src/main/java/com/google/gson/typeadapters/RuntimeTypeAdapterFactory.java Outdated Show resolved Hide resolved
extras/src/test/java/com/google/gson/graph/GraphAdapterBuilderTest.java Outdated Show resolved Hide resolved
@eamonnmcmanus eamonnmcmanus merged commit 26a1928 into google:master Sep 18, 2021
@Marcono1234 Marcono1234 deleted the marcono1234/RuntimeTypeAdapterFactory-no-internal-dependencies branch September 18, 2021 00:42
This was referenced Jul 23, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Jun 2, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamonnmcmanus eamonnmcmanus eamonnmcmanus approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeTypeAdapterFactory depends on internal API (JPMS, Java 9+)
2 participants
@Marcono1234 @eamonnmcmanus