Support jsonValue in JsonTreeWriter
#1819
Conversation
There was a problem hiding this comment.
The JsonElement javadoc is now incorrect:
It could either be a {@link JsonObject}, a {@link JsonArray}, a {@link JsonPrimitive}
or a {@link JsonNull}.
Additionally this new JsonElement subclass can break the logic in JsonTreeReader.peek() and MapTypeAdapterFactory.Adapter.keyToString(JsonElement).
I am not sure if adding this class is really a good solution. Maybe this problem cannot be solved in a reasonable way for JsonTreeWriter other than throwning an exception.
Note that I am not a member of this project.
gson/src/main/java/com/google/gson/internal/bind/JsonTreeWriter.java
Outdated
Show resolved
Hide resolved
|
Can update the map key and doc. I don't expect this would ever appear in a reader, but maybe converting it to a JsonElement directly rather than a raw value could allow seamless interoperability. Will look |
|
@Marcono1234 I managed to make this work without introducing a new type, which came out a lot simpler and just reuses existing types by eagerly parsing the JSON. It's a little less performant in theory for large blobs, but seems worth the tradeoff and maybe even adds a bit of extra peace of mind for validating the JSON structure is sound. |
|
Note that a workaround for anyone that needs this and is willing to touch internal APIs - you can convert your string to a |
There was a problem hiding this comment.
Looks good thanks! This makes it much more reliable.
then write it directly to the writer with GSON's internal JsonElement adapter (i.e.
TypeAdapters.JSON_ELEMENT.write(writer, jsonElement))
Could you please explain which use case you are describing? I assume you are not talking about overriding JsonWriter.jsonValue(...)? For serializing a JsonElement to JSON you would normally use one of the Gson.toJson(JsonElement, ...) methods.
| * @since 2.8.7 | ||
| */ | ||
| @Override public JsonWriter jsonValue(String value) throws IOException { | ||
| put(JsonParser.parseString(value)); |
There was a problem hiding this comment.
As pointed out in the previous review comment, could you please check for null and then performreturn nullValue(); instead; the documentation demands this behavior, currently it would throw a NullPointerException.
| .name("string") | ||
| .jsonValue("\"hello\"") | ||
| .name("null") | ||
| .jsonValue("null") |
There was a problem hiding this comment.
Could you please also call jsonValue(null)? E.g.:
| .jsonValue("null") | |
| .jsonValue("null") | |
| .name("javaNull") | |
| .jsonValue(null) |
Resolves #1289 and resolves #1268
Supersedes #1651
This adds support for
JsonWriter#jsonValue()inJsonTreeWriter, which currently just throws a nondescript assertion error