Fix JsonReader.nextDouble() throwing wrong exception type for NaN and Infinity #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Infinity The documentation says that a NumberFormatException will be thrown in case the value is not finite (i.e. NaN or Infinity). However, the JsonReader implementation actually throws a MalformedJsonException. Note that JsonTreeReader currently throws a NumberFormatException, as expected.
inder123
reviewed
Aug 26, 2020
| @@ -907,7 +907,7 @@ public double nextDouble() throws IOException { | |||
| peeked = PEEKED_BUFFERED; | |||
| double result = Double.parseDouble(peekedString); // don't catch this NumberFormatException. | |||
| if (!lenient && (Double.isNaN(result) || Double.isInfinite(result))) { | |||
| throw new MalformedJsonException( | |||
There was a problem hiding this comment.
Seems like it is indeed bad JSON since JSON forbids NaN and infinities.
The number may actually be in correct format.
There was a problem hiding this comment.
Though then the question is why NumberFormatException is thrown in the first place when the number cannot be parsed as double, int or long since it is malformed JSON in these cases as well.
|
When in doubt, I prefer to preserve the current behavior. |
|
So should the documentation then be updated to state that a MalformedJsonException is thrown and JsonTreeReader be adjusted accordingly? Because the current behavior is inconsistent. |
Marcono1234
deleted the
marcono1234/JsonReader-nan-infinity-exception-type
branch
Marcono1234
added a commit
to Marcono1234/gson
that referenced
this pull request
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation says that a NumberFormatException will be thrown in case the value is not finite (i.e. NaN or Infinity). However, the JsonReader implementation actually throws a MalformedJsonException.
Note that JsonTreeReader currently throws a NumberFormatException, as expected.