Fix JsonWriter documentation regarding top-level value #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 7159 allows any top-level value (not only arrays or objects) [0], however when google#773 added this functionality it appears the author forgot to update the documentation of these classes. [0] https://tools.ietf.org/html/rfc7159#appendix-A > Changed the definition of "JSON text" so that it can be any JSON > value, removing the constraint that it be an object or array.
|
@eamonnmcmanus, can you please have a look? |
Marcono1234
changed the title
Marcono1234
deleted the
marcono1234/fix-javadoc-any-top-level-value-allowed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 7159 allows any top-level value (not only arrays or objects) [0], however when #773 added this functionality it appears the author forgot to update the documentation of these classes.
[0] https://tools.ietf.org/html/rfc7159#appendix-A