Fix for issue #9 for 32-bit architectures #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target host is a 32-bit Debian 9 on Armv7 Cortex-A7 dual-core 1 GHz using the official golang v.14 ARMv6l build. Anything over 26 was giving issue google#9. Was able to compile fine, however since I don't have access to a TPM1.2 device but a TPM2.0, the file /sys/kernel/security/tpm0/binary_bios_measurements does not exist for me.
|
Will this be accepted? I could use that change as well. |
|
+1 |
ericchiang
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Sorry this fell off our radar.
Fixes google/go-attestation#230
For posterity, this pattern is the recommended way to reference C arrays as Go slices
https://github.com/golang/go/wiki/cgo#turning-c-arrays-into-go-slices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target host is a 32-bit Debian 9 on Armv7 Cortex-A7 dual-core 1 GHz using the official golang v.14 ARMv6l build. Anything over the value 26 was resulting in issue #9. Was able to compile and work normally. However, since I don't have access to a TPM1.2 device but a TPM2.0, the file /sys/kernel/security/tpm0/binary_bios_measurements does not exist for me and therefore not able to verify behavior.