Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Interceptor Wrapping #307

Open
empijei opened this issue May 27, 2021 · 1 comment
Open

Support Interceptor Wrapping #307

empijei opened this issue May 27, 2021 · 1 comment
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request v0.1

Comments

@empijei
Copy link
Contributor

empijei commented May 27, 2021

For various reasons (e.g. experiments) it might be useful to wrap interceptors.

The problem is that once an interceptor gets wrapped, it will not be matched to its configurations anymore.

I propose to add the following feature:

When a Mux is constructed we match configs with their interceptor, but we also check if the the interceptor has a

Unwrap() Interceptor

method on it.

If so, we recursively check configs against the inner interceptors.

@kele
Copy link
Collaborator

kele commented Jun 2, 2021

Is my understanding correct that we don't need anything extra to support this case? Maybe just a GoDoc example?

@kele kele added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request v0.1
Projects
None yet
Development

No branches or pull requests

2 participants