Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove savePath before looking for packages #99

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

benmoss
Copy link

@benmoss benmoss commented Jan 11, 2022

This prevents users who save their licenses into their source tree from getting those as packages themselves.

Fixes #91

This prevents users who save their licenses into their source tree from
getting those as packages themselves.
@dprotaso
Copy link
Contributor

cc @wlynch

@wlynch
Copy link
Contributor

wlynch commented Jan 11, 2022

@jimmale This is effectively a revert of #90. Since this is causing problems for people I'm going to approve this so we can roll back to a safe state - we can do some more thinking for how we want to support your use case moving forward.

@wlynch wlynch merged commit c781b42 into google:master Jan 11, 2022
@benmoss benmoss deleted the exclude-saved-licenses branch January 12, 2022 14:42
@benmoss
Copy link
Author

benmoss commented Jan 12, 2022

If we could exclude the savePath from the directories being scanned I think that could solve both problems

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rerunning go-licenses now breaks when using --force and already have an output dir
3 participants