Prepend path separator to GOROOT prefix when checking for stdlib packages #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, this code was simply checking if the
build.Default.GOROOT
was a prefix of the target package path to see if the package was from the stdlib. this was failing for me, as the default GOROOT/usr/local/go
was being used (since I don't have one set), but all of my packages lived under/usr/local/google/...
.sadly, there's no better solution in the
filepath
package to check if a path is nested under another path.