Use predefined types for pre-commit over file endings#815
Merged
Conversation
Collaborator
|
Thanks for the contribution! I'm not very familiar with the pre-commit tool, but this looks ok. |
johnbartholomew
force-pushed
the
patch-1
branch
from
e437b5b to
751aedf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit has some predefined types that match the correct extensions. The jsonnet type matches https://github.com/pre-commit/identify/blob/40af39f8124a4e8029ff3716c2b0bbf2e1e5fb1e/identify/extensions.py#L139 and https://github.com/pre-commit/identify/blob/40af39f8124a4e8029ff3716c2b0bbf2e1e5fb1e/identify/extensions.py#L151 which are exactly the file endings used before