Skip to content

fix: do not mutate std.removeAt parameters #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnbartholomew merged 1 commit into from
Jan 27, 2026
Merged

fix: do not mutate std.removeAt parameters #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion builtins.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2485,6 +2485,7 @@ func builtinRemove(i *interpreter, arrv value, ev value) (value, error) {
}

func builtinRemoveAt(i *interpreter, arrv value, idxv value) (value, error) {
var newArr []*cachedThunk
arr, err := i.getArray(arrv)
if err != nil {
return nil, err
Expand All @@ -2494,7 +2495,8 @@ func builtinRemoveAt(i *interpreter, arrv value, idxv value) (value, error) {
return nil, err
}

newArr := append(arr.elements[:idx], arr.elements[idx+1:]...)
Copy link
Copy Markdown
Collaborator

@johnbartholomew johnbartholomew Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go's funky append() behaviour strikes again.

newArr = append(newArr, arr.elements[:idx]...)
newArr = append(newArr, arr.elements[idx+1:]...)
return makeValueArray(newArr), nil
}

Expand Down
7 changes: 7 additions & 0 deletions testdata/builtinRemoveAt2.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[
"quux",
"foo",
"bar",
"foo",
"bar"
]
3 changes: 3 additions & 0 deletions testdata/builtinRemoveAt2.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
local a = ['quux','foo','bar'];
local b = std.removeAt(a,0);
a+b
Empty file added testdata/builtinRemoveAt2.linter.golden
View file
Open in desktop
Empty file.