Fixes for the Bazel module#798
Merged
Merged
Conversation
This is mostly so that I can add it as the test module to be used in the bazel registry presubmit
johnbartholomew
force-pushed
the
bazelfixes
branch
from
c6d0c56 to
f82532a
Compare
johnbartholomew
force-pushed
the
bazelfixes
branch
from
f82532a to
1add1e1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to update the Bazel registry for 0.21.0-rc2 (bazelbuild/bazel-central-registry#4015) revealed a problem.
The rules_go go_sdk.download module extension function should not be given a name= attribute; that is only allowed in a root module, so it works for building just go-jsonnet but does not work when the jsonnet_go Bazel module is imported for use in another Bazel module.