Skip to content

Pin bazel version to 7.5.0, and require up-to-date lockfile for CI#795

Merged
johnbartholomew merged 2 commits into
google:masterfrom
johnbartholomew:bazelisk
Mar 12, 2025
Merged

Pin bazel version to 7.5.0, and require up-to-date lockfile for CI#795
johnbartholomew merged 2 commits into
google:masterfrom
johnbartholomew:bazelisk

Conversation

@johnbartholomew
Copy link
Copy Markdown
Collaborator

Bazel 7 is currently in maintenance and supported to the end of 2026.

The CI build should require an up-to-date lockfile so that we can try to catch before merging if Bazel dep changes are made without the corresponding lockfile change.

The Bazel lockfile is specific to the Bazel version (because Bazel itself is considered a build dependency), so the recommendation is to use Bazelisk to build with a specific Bazel version: https://bazel.build/external/lockfile#best-practices

…I build

Bazel 7 is currently in maintenance and supported to the end of 2026.

The CI build should require an up-to-date lockfile so that we can try
to catch before merging if Bazel dep changes are made without the
corresponding lockfile change.
Otherwise if the submodule is initialized Bazel will try to build
it when running commands like bazel test //...:all. But that doesn't
work because the cpp-jsonnet directory is not part of the same
bazel module.

Perhaps there is a better way to fix it but just ignoring the
cpp-jsonnet directory seems to be ok.
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 12, 2025

Coverage Status

coverage: 55.574%. remained the same
when pulling b9ae88d on johnbartholomew:bazelisk
into bc787d6 on google:master.

@johnbartholomew johnbartholomew merged commit b9ae88d into google:master Mar 12, 2025
@johnbartholomew johnbartholomew deleted the bazelisk branch March 12, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants