Skip to content

chore: Update dependency versions#794

Merged
johnbartholomew merged 3 commits into
google:masterfrom
andrii-korotkov-verkada:update-dependencies
Mar 11, 2025
Merged

chore: Update dependency versions#794
johnbartholomew merged 3 commits into
google:masterfrom
andrii-korotkov-verkada:update-dependencies

Conversation

@andrii-korotkov-verkada
Copy link
Copy Markdown
Contributor

@andrii-korotkov-verkada andrii-korotkov-verkada commented Mar 7, 2025

Bump go and dependencies to the versions close to the latest.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Mar 7, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 11, 2025

Coverage Status

coverage: 55.574%. remained the same
when pulling aa22466 on andrii-korotkov-verkada:update-dependencies
into 52bb10f on google:master.

@johnbartholomew
Copy link
Copy Markdown
Collaborator

I think the Bazel build can use Go 1.23 by explicitly pulling in the right version using rules_go. In MODULE.bazel , after the bazel_dep for rules_go, add:

go_sdk = use_extension("@io_bazel_rules_go//go:extensions.bzl", "go_sdk")
go_sdk.download(
    name = "go_sdk",
    version = "1.23.7",
)

Probably ok to also bump the bazel module deps too, rules_go to 0.53.0 and gazelle to 0.42.0.

With the explicit Go 1.23 SDK it should then be possible to update all the go deps including bringing golang.org/x/crypto up to v0.36.0. (And then rerun gazelle again).

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
@andrii-korotkov-verkada
Copy link
Copy Markdown
Contributor Author

@johnbartholomew, it worked! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants