Skip to content

fix: output original value from array in std.minArray and std.maxArray instead of result of keyF#791

Merged
johnbartholomew merged 3 commits into
google:masterfrom
eduardosm:fix-minArray-maxArray-keyF
Mar 11, 2025
Merged

fix: output original value from array in std.minArray and std.maxArray instead of result of keyF#791
johnbartholomew merged 3 commits into
google:masterfrom
eduardosm:fix-minArray-maxArray-keyF

Conversation

@eduardosm
Copy link
Copy Markdown
Contributor

Fixes #790.

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 10, 2025

Coverage Status

coverage: 55.574% (+0.1%) from 55.46%
when pulling 52bb10f on eduardosm:fix-minArray-maxArray-keyF
into 106c8f0 on google:master.

@johnbartholomew
Copy link
Copy Markdown
Collaborator

Thanks for finding and fixing this!

@johnbartholomew johnbartholomew force-pushed the fix-minArray-maxArray-keyF branch from 2d82c11 to 75c8d25 Compare March 11, 2025 00:44
@github-advanced-security
Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@johnbartholomew johnbartholomew force-pushed the fix-minArray-maxArray-keyF branch from 75c8d25 to 52bb10f Compare March 11, 2025 00:47
@johnbartholomew johnbartholomew merged commit 52bb10f into google:master Mar 11, 2025
@johnbartholomew
Copy link
Copy Markdown
Collaborator

Rebased, added support for the optional onEmpty parameter (for parity with the C++ version which already had this), and merged.

Thanks again for the contribution!

@eduardosm eduardosm deleted the fix-minArray-maxArray-keyF branch March 11, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

std.maxArray and std.minArray do not produce the correct result when passed a non-identity keyF function

4 participants