Skip to content

Fix interface conversion from int types to float64 #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shrdlu68 wants to merge 1 commit into from
Closed

Fix interface conversion from int types to float64 #741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion interpreter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,7 +950,8 @@ func jsonToValue(i *interpreter, v interface{}) (value, error) {
case bool:
return makeValueBoolean(v), nil
case int, int8, int16, int32, int64:
return makeDoubleCheck(i, v.(float64))
val, _ := v.(int64)

@suzuki-shunsuke suzuki-shunsuke Jun 3, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we need to convert the value to int64.

Is the following code wrong?

return makeDoubleCheck(i, float64(v))

@suzuki-shunsuke suzuki-shunsuke Jun 3, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

makeDoubleCheck(i, float64(v)) causes a compile error.

cannot convert v (variable of type interface{}) to type float64: need type assertion

return makeDoubleCheck(i, float64(val))
case float64:
return makeDoubleCheck(i, v)

Expand Down