Remove dependency on cpp-jsonnet submodule from C bindings#482
Conversation
|
We can probably go forward with this, but I don't like that we can now accidentally diverge from the original headers without noticing it. Maybe we could keep a copy of the header in the repo and use it for compiling libgojsonnet. We could then check if it's the same as in cpp-jsonnet in tests.sh (which depends on cpp-jsonnet anyway). Let me think about this. |
This change allows us to build libgojsonnet from tarball downloaded from GitHub releases.
1b4d7f5 to
2f73f61
Compare
|
Four and a half years later, this pull request still seems useful to me. Looking at the history of libjsonnet.h in the C++ repository, the declarations being copied here last changed in 2014: google/jsonnet@2c5fd87#diff-ee89e9022b7fdd09da47ce82a4b9b1fd6901967ffbbd8d1a30249a18414b715f It would be nice to have an automated check in the test suite that the copied declarations don't diverge... but given the rate of change here it doesn't seem like a high urgency problem. I've rebased the change onto master. |
|
Merged. Thanks for the contribution! |
This change allows us to build libgojsonnet from tarball downloaded from
GitHub releases.