feat: Add support for GitHub-hosted runner API endpoints #3487
+2,636
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
gmlewis
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3487 +/- ##
==========================================
+ Coverage 91.02% 91.16% +0.14%
==========================================
Files 179 181 +2
Lines 15561 15809 +248
==========================================
+ Hits 14165 14413 +248
Misses 1223 1223
Partials 173 173 ☔ View full report in Codecov by Sentry. |
gmlewis
requested changes
Feb 20, 2025
There was a problem hiding this comment.
Thank you, @atilsensalduz !
This is looking great!
There are a few minor tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
Implement new methods for managing GitHub-hosted runners, including functionalities for creating, updating, deleting, and retrieving details about hosted runners. References: - GitHub REST API: https://docs.github.com/en/rest/actions/hosted-runners Signed-off-by: atilsensalduz <[email protected]>
gmlewis
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Thank you, @atilsensalduz!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
@stevehipwell - might you have time for a code review? Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for the GitHub-hosted runner API endpoints in the go-github library, addressing Issue #3461.
Changes Include:
Additional Information:
API Reference: GitHub REST API: Hosted Runners.
Please let me know if any additional changes or improvements are needed!
Fixes: #3461.