Skip to content

Change type of HookDelivery.InstallationID to Int64. #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Change type of HookDelivery.InstallationID to Int64. #2235

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a33ade
Change type of HookDelivery.InstallationID to Int64.
pierce-m Dec 16, 2021
8ba2c80
Add omitempty.
pierce-m Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions github/github-accessors.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion github/github-accessors_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions github/github-stringify_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion github/repos_hooks_deliveries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type HookDelivery struct {
StatusCode *int `json:"status_code"`
Event *string `json:"event"`
Action *string `json:"action"`
InstallationID *string `json:"installation_id"`
InstallationID *int64 `json:"installation_id"`
RepositoryID *int64 `json:"repository_id"`

// Request is populated by GetHookDelivery.
Expand Down
4 changes: 2 additions & 2 deletions github/repos_hooks_deliveries_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ func TestHookDelivery_Marshal(t *testing.T) {
StatusCode: Int(1),
Event: String("guid"),
Action: String("guid"),
InstallationID: String("guid"),
InstallationID: Int64(1),
RepositoryID: Int64(1),
Request: &HookRequest{
Headers: header,
Expand All @@ -310,7 +310,7 @@ func TestHookDelivery_Marshal(t *testing.T) {
"status_code": 1,
"event": "guid",
"action": "guid",
"installation_id": "guid",
"installation_id": 1,
"repository_id": 1,
"request": {
"headers": {
Expand Down