Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for actions/hosted-runners endpoints #3461

Open
stevehipwell opened this issue Feb 5, 2025 · 4 comments · May be fixed by #3487
Open

Add support for actions/hosted-runners endpoints #3461

stevehipwell opened this issue Feb 5, 2025 · 4 comments · May be fixed by #3487

Comments

@stevehipwell
Copy link
Contributor

The REST endpoints for GitHub-hosted larger runners have been announced as GA.

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 5, 2025

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.
Also feel free to perform a code review on any PR that has the label "NeedsReview" - we appreciate those contributions too!
We have a REVIEWERS file that you could add your username to if you are willing to be contacted when reviews are needed.

Please check out our CONTRIBUTING.md guide to get started. (In particular, please remember to go generate ./... and don't use force-push to your PRs.)

Thank you!

@atilsensalduz
Copy link

Hey everyone,

I’d love to take this on! Since this will be my first contribution, I’m not too familiar with the codebase, but I’ve already gone through the contributing guide. My plan is to create a new file, actions_github_runners.go, similar to actions_runners.go.

Any tips or guidance you could share would be greatly appreciated! 😊

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 20, 2025

Thank you, @atilsensalduz!
It's yours. How about actions_hosted_runners.go?

I'm happy to hear that you read CONTRIBUTING.md. For guidance, I recommend you read through a similar collection of endpoints, such as actions_runners.go or another one of your choice, and read the official (linked) GitHub documentation for both the already-implemented collection and for the collection you will be implementing, and follow the already-established pattern for how you create your new endpoints along with their corresponding tests.

Make sure your tests pass locally along with the other step-4 scripts in CONTRIBUTING.md. Then, when you are happy with your results, go ahead and post a PR.

@atilsensalduz
Copy link

Hey everyone,

I’ve opened a PR for the hosted runner OSS endpoints. I’d really appreciate it if you could take a look when you get a chance. Once it’s reviewed, I’ll proceed with the enterprise endpoints.

Thanks a lot! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants