Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Docker-Content-Digest check #262

Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

See GoogleContainerTools/kaniko#298

Too many registries don't work correctly, and we don't want to hard-code
them all.

Too many registries don't work correctly, and we don't want to hard-code
them all.
@codecov-io
Copy link

Codecov Report

Merging #262 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #262      +/-   ##
========================================
+ Coverage   54.99%    55%   +<.01%     
========================================
  Files          58     58              
  Lines        2473   2469       -4     
========================================
- Hits         1360   1358       -2     
  Misses        895    895              
+ Partials      218    216       -2
Impacted Files Coverage Δ
pkg/v1/remote/image.go 70.29% <100%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3165313...40d761a. Read the comment docs.

@mattmoor
Copy link
Collaborator

(sigh) wtf...

@jonjohnsonjr jonjohnsonjr merged commit e3df2a4 into google:master Aug 23, 2018
@jonjohnsonjr jonjohnsonjr deleted the tags-are-literally-the-worst branch August 23, 2018 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants