chore(deps): relax go directive to permit 1.22.x #2047
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the go directive to 1.23.0 requires all consumers of the module to be building with 1.23.0 or newer release of Go 1.23 and to update their own go.mod accordingly — this seems unnecessarily restrictive for a library module, particularly as the code itself doesn't currently use any modern language constructs and builds fine even with older Go versions. Instead set the go directive to 1.22.0 and use the toolchain directive to recommend the latest 1.23.x when building locally. Note: this also includes a run of `hack/bump-deps.sh` to ensure all deps are compatible with go1.22.0 as well Fixes google#2045 Signed-off-by: Dominic Evans <[email protected]>
Ensure that the go and toolchain directives in go.mod are kept in sync and pinned at the desired support level (N-1 and N) Note, we are also pinning k8s.io packages to an explicit v0.31.5 version in the pkg/authn go.mod files in order to avoid prerelease versions that `go get -u` will pickup. Signed-off-by: Dominic Evans <[email protected]>
Author
|
@imjasonh would you be happy to take a look at this PR? |
|
@imjasonh @jonjohnsonjr Bumping this PR for review, this is needed for us to stay on Go 1.22 in sigstore. |
This was referenced Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the go directive to 1.23.0 requires all consumers of the module
to be building with 1.23.0 or newer release of Go 1.23 and to update
their own go.mod accordingly — this seems unnecessarily restrictive for
a library module, particularly as the code itself doesn't currently use
any modern language constructs and builds fine even with older Go
versions.
Instead set the go directive to 1.22.0 and use the toolchain directive
to recommend the latest 1.23.x when building locally.
Note: this also includes a run of
hack/bump-deps.shto ensure all depsare compatible with go1.22.0 as well
Fixes #2045