blob/s3blob: custom endpoints with s3 and aws sdk v2 #3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs google#3472 Signed-off-by: Carlos Alexandro Becker <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3473 +/- ##
==========================================
+ Coverage 73.07% 73.14% +0.07%
==========================================
Files 113 113
Lines 14979 14990 +11
==========================================
+ Hits 10946 10965 +19
+ Misses 3270 3261 -9
- Partials 763 764 +1 ☔ View full report in Codecov by Sentry. |
vangent
reviewed
Aug 19, 2024
Signed-off-by: Carlos Alexandro Becker <[email protected]>
vangent
requested changes
Aug 21, 2024
Signed-off-by: Carlos Alexandro Becker <[email protected]>
Signed-off-by: Carlos Alexandro Becker <[email protected]>
vangent
approved these changes
Aug 21, 2024
|
Thanks @caarlos0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that this is needed in aws-sdk-v2 for minio to work.
see: minio/docs#406 (comment)
refs #3472