Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions.md: correct UpdateMSU options #701

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

iamacarpet
Copy link
Contributor

@iamacarpet iamacarpet commented Jul 21, 2023

The example for UpdateMSU in the docs is misleading.

The option need to be an array of updates, each itself an array of arguments.

@google-cla
Copy link

google-cla bot commented Jul 21, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

@TsekNet TsekNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can you move each list argument to it's own line to make it easier for humans to read?

@TsekNet
Copy link
Contributor

TsekNet commented Jan 2, 2024

ping @iamacarpet

@iamacarpet
Copy link
Contributor Author

Sorry @TsekNet , I'll get this sorted.

@iamacarpet
Copy link
Contributor Author

There we go @TsekNet ,

I hope you don't mind me also documenting the argument list, as I found myself having to dive into the code again to confirm the hash format (until I realised I could guess it from the hash length, but that isn't the point) :).

@mit-da mit-da merged commit 410eb25 into google:master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants