Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Security Command Center integration #100

Merged
merged 36 commits into from
Jul 21, 2022
Merged

Security Command Center integration #100

merged 36 commits into from
Jul 21, 2022

Conversation

mikouaj
Copy link
Member

@mikouaj mikouaj commented Jul 15, 2022

This PR introduces Security Command Center integration.

  • The SCC is a new configurable output
  • Policies were enhanced with a sccCategory and severity
  • The ./gke-policy configure scc command was introduced to optionally configure SCC source beforehand (as creation of SCC source requires more IAM permissions)

mikouaj added 28 commits July 1, 2022 11:19
@mikouaj
PolicyAgent is an interface now
5815bcd
@mikouaj
Outputs use ValidationReport*, refactored outputs
7d75551
@mikouaj
Merge branch 'main' into outputs-ng
f350664
@mikouaj
Merge branch 'main' into outputs-ng
811a5f0
@mikouaj
Added tests to validation report
181cbaa
@mikouaj
Cluster discovery skipped zonal clusters due to name parttern mismatch
df82fb3
@mikouaj
removed old commented code
fe87f93
@mikouaj
Trigger cluster discover on a project from CLI
d7cd979
@mikouaj
When discovery enabled in CLI, cluster project is added only when not…
16d1d31 
… empty
@mikouaj
Merge branch 'cli-discovery' into outputs-ng
60f437d
@mikouaj
Merge branch 'zonal-discovery-fix' into outputs-ng
b8195a6
@mikouaj
Added tabwriter
3570b5d
@mikouaj
Added demo GIF ! :-)
8f017b6
@mikouaj
scc draft one
670578e
@mikouaj
Discovery messages more specific
ea1a6a2
@mikouaj
Adding tests
7f20119
@mikouaj
Collector's draft
ef54d6b
@mikouaj
Merge branch 'outputs-ng' into scc-output
caf61f9
@mikouaj
Drafting collector
0ef01e9
@mikouaj
Fixed missing validation date in a report
c52238c
@mikouaj
Merge branch 'outputs-ng' into scc-output
02ed27d
@mikouaj
Added category and severity to policies
2153068
@mikouaj
Added config, command, outputs integration and tests
fe0a7c8
@mikouaj
scc collector source create fix + added tests
ff7f5c0
@mikouaj
Updated policies
5fedaaa
@mikouaj
SCC collector runs in multiple goroutines now
09ff0b5
@mikouaj
Added Name() func to output if and used it in app for communication p…
848330d 
…urposes
@mikouaj
Merge branch 'main' into scc-output
33a2f11
@mikouaj mikouaj added the enhancement New feature or request label Jul 15, 2022
ewojtach
ewojtach approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@ewojtach ewojtach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!
it would be great to have some documentation on it in user guide and main readme file.

@mikouaj mikouaj merged commit 29524f4 into main Jul 21, 2022
@mikouaj mikouaj deleted the scc-output branch July 21, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewojtach ewojtach ewojtach approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikouaj @ewojtach