Make Gin dynamic class wrapping compatible with pickle. #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_348047963
branch
4 times, most recently
from
ca5caf8 to
1010954
Compare
copybara-service
bot
force-pushed
the
test_348047963
branch
from
1010954 to
f793279
Compare
A new take on how to do this, since the wrapt approach also didn't end up working. This approach does the following: - When wrapping a class where mutation should be disallowed, this dynamically subclasses the class's metaclass, and intercepts/wraps its `__call__`. - However, this metaclass then returns an instance of the *original* type, which allows pickling to work. To preserve proper signature checking, there are a few changes also to the general Gin wrapper function, to always use the signature associated with the right `__init__`/`__new__` function. As a result of this change, it's no longer permissible to subclass the wrapped class returned by gin.external_configurable, so the test case for this has been removed. This should be an ok tradeoff, as no one is relying on this behavior and it's a pretty dubious use case to begin with. PiperOrigin-RevId: 348525899
copybara-service
bot
force-pushed
the
test_348047963
branch
from
f793279 to
bf622d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Gin dynamic class wrapping compatible with pickle.
A new take on how to do this, since the wrapt approach also didn't end up working. This approach does the following:
__call__.To preserve proper signature checking, there are a few changes also to the general Gin wrapper function, to always use the signature associated with the right
__init__/__new__function.As a result of this change, it's no longer permissible to subclass the wrapped class returned by gin.external_configurable, so the test case for this has been removed. This should be an ok tradeoff, as no one is relying on this behavior and it's a pretty dubious use case to begin with.