Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change in string for condition check #232

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

VadirajKranam
Copy link
Contributor

@VadirajKranam VadirajKranam commented Nov 28, 2024

Fixes #231

Copy link

google-cla bot commented Nov 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@eliben
Copy link
Member

eliben commented Dec 4, 2024

@VadirajKranam thanks for the report and the fix. Please sign the CLA so we can proceed with reviewing and merging your PR

@VadirajKranam
Copy link
Contributor Author

Hey @eliben i have signed the CLA

@eliben eliben merged commit 3d14f40 into google:main Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:awaiting user response Awaiting a response from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"genai.WithCredentialsFile(...)" fails because of wrong validation
2 participants