Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

genai: factor out uploadFile function for examples #173

Merged
merged 2 commits into from
Jul 13, 2024
Merged

genai: factor out uploadFile function for examples #173

merged 2 commits into from
Jul 13, 2024

Conversation

eliben
Copy link
Member

@eliben eliben commented Jul 13, 2024

We're going to have several more examples that upload files; factor out a function that does this properly, checking for status etc. It's like the function client_test uses, but without the testing.T scaffold.

@eliben eliben requested a review from jba July 13, 2024 13:38
@eliben
Copy link
Member Author

eliben commented Jul 13, 2024

Should I also use this function for the example of UploadFile itself?

@eliben eliben merged commit 608d329 into main Jul 13, 2024
2 checks passed
@eliben eliben deleted the upload branch July 13, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants