Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update goVer function to use strings.Builder for better performance #162

Closed
wants to merge 1 commit into from
Closed

Update goVer function to use strings.Builder for better performance #162

wants to merge 1 commit into from

Conversation

kasugamirai
Copy link
Contributor

No description provided.

eliben
eliben reviewed Jul 9, 2024
View reviewed changes
Copy link
Member

@eliben eliben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this file is copied from another repository - see the README adjacent to it

That said, it seems like the version is only copmuted once, so performance doesn't appear to be a major concern - unless you have benchmarks to show that it is?

@eliben eliben added the status:awaiting user response Awaiting a response from the author label Jul 9, 2024
@kasugamirai kasugamirai closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliben eliben eliben left review comments

Assignees
No one assigned
Labels
status:awaiting user response Awaiting a response from the author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasugamirai @eliben