Skip to content

Update lora_tuning.ipynb #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

Update lora_tuning.ipynb #582

merged 1 commit into from
May 7, 2025

Conversation

@sachinprasadhs
Copy link
Contributor

@sachinprasadhs sachinprasadhs commented May 6, 2025 •
edited
Loading

Update from Keras NLP to Keras Hub

Description of the change

Motivation

Type of change

Choose one: (Bug fix | Feature request | Documentation | Other)

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@sachinprasadhs
Update lora_tuning.ipynb
e42368e 
Update from Keras NLP to Keras Hub
@sachinprasadhs sachinprasadhs requested a review from a team as a code owner May 6, 2025 18:05
@review-notebook-app
Copy link

review-notebook-app bot commented May 6, 2025

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:documentation Update docs labels May 6, 2025
bebechien
bebechien approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@bebechien bebechien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bebechien bebechien merged commit 2989ed9 into google:main May 7, 2025
5 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 7, 2025
@sachinprasadhs sachinprasadhs deleted the patch-2 branch May 7, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bebechien bebechien bebechien approved these changes

Assignees

No one assigned

Labels

component:documentation Update docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sachinprasadhs @bebechien