Drop the "(index=..., value=...)" format for printing std::variant values.
#1400
+5
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
…values. Instead, we now delegate to the inner domain for both human-readable and source code printing. The reason is that the users were finding the old human-readable format confusing. With this change, `VariantPrinter` and `VariantDomainPrinter` became identical, so I dropped the latter. PiperOrigin-RevId: 681577434
copybara-service
bot
force-pushed
the
cl/681234563
branch
from
14f31fd
to
e47a78c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the "(index=..., value=...)" format for printing
std::variantvalues.Instead, we now delegate to the inner domain for both human-readable and
source code printing. The reason is that the users were finding the old
human-readable format confusing.
With this change,
VariantPrinterandVariantDomainPrinterbecame identical,so I dropped the latter.