Compare mount by value instead of reference #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephlr
approved these changes
May 2, 2024
NymanRobin
force-pushed
the
compare-mount-by-value
branch
from
fcea5c9
to
227fca8
Compare
|
Thanks for the comments, I fixed them now! |
josephlr
approved these changes
May 2, 2024
ebiggers
reviewed
May 2, 2024
This has to be since the mounts are reloaded each time a mount is added. In case of two mounts mounting at the same time there will be a race condition for applying policy. Signed-off-by: NymanRobin <[email protected]>
NymanRobin
force-pushed
the
compare-mount-by-value
branch
from
227fca8
to
068b9f8
Compare
|
Thanks for the comments @ebiggers, I fixed up the stuff. Hope it looks good now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has to be since the mounts are reloaded each time a mount is added.
In case of two mounts mounting at the same time there will be a race condition for applying policy.
I added the unit test in mountpoint for my sanity while developing and some kind of documentation of the issue.
This fixes issue #411