Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noto Serif TC: Version 2.003-H1;hotconv 1.1.1;makeotfexe 2.6.0 added #8056

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Noto Serif TC: Version 2.003-H1;hotconv 1.1.1;makeotfexe 2.6.0 added #8056

merged 1 commit into from
Aug 20, 2024
+13 −5

Conversation

simoncozens
Copy link
Collaborator

Taken from the upstream repo https://www.github.com/notofonts/noto-cjk at commit https://www.github.com/notofonts/noto-cjk/commit/985fa52c81c1d6692ccdd82bc3656e8fb932fd89.

PR Checklist:

  • Family categorization tags collected from the type design team with the Categories Form
  • minisite_url definition in the METADATA.pb file for commissioned projects
  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.
  • Fontbakery checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 regression checks for revisions on all projects that are currently in production
  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media formatted visual assets for all new commissioned projects in the Drive directory, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet

@simoncozens simoncozens force-pushed the gftools_packager_ofl_notoseriftc branch from 6d28bd9 to c27d9e4 Compare August 19, 2024 15:28
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@simoncozens
Copy link
Collaborator Author

Major changes to this one:

And some other changes I can't explain because they're not in the NEWS:

  • U+615D 慝 now takes the simplified form
  • U+7661 癡 now takes Japanese/traditional form
  • U+22ACF 𢫏 got a redesign, but it looks an improvement to my eyes
  • U+88CA 裊 bottom left of bird radical has changed, again looks like an improvement

@simoncozens simoncozens force-pushed the gftools_packager_ofl_notoseriftc branch from c27d9e4 to 6d17dab Compare August 19, 2024 16:02
@github-actions GitHub Actions
Copy link

FontBakery report

fontbakery version: 0.12.10

Experimental checks

These won't break the CI job for now, but will become effective after some time if nobody raises any concern.

[1] NotoSerifTC[wght].ttf
🔥 FAIL Checking that the typoAscender exceeds the yMax of the /Agrave.
  • 🔥 FAIL

    OS/2.sTypoAscender value should be greater than 932, but got 880 instead


    [code: typoAscender]

All other checks

[28] NotoSerifTC[wght].ttf
🔥 FAIL METADATA.pb: Check URL on copyright string is the same as in repository_url field.

But: font copyright string has 'http://www.adobe.com'

[code: mismatch]
🔥 FAIL Shapes languages in all GF glyphsets.
  • 🔥 FAIL

    GF_Latin_Vietnamese glyphset:

Language FAIL messages
vi_Latn (Vietnamese) Some mark glyphs were missing: ◌̂, ◌̃, ◌̆, ◌̉, ◌̛, ◌̣
[code: failed-language-shaping]
🔥 FAIL Does DESCRIPTION file contain broken links?
🔥 FAIL Combined length of family and style must not exceed 32 characters.
  • 🔥 FAIL

    Variable font instance name 'Noto Serif TC ExtraLight ExtraLight' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 266 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif TC ExtraLight ExtraLight' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 266 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif TC ExtraLight SemiBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 274 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif TC ExtraLight SemiBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 274 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif TC ExtraLight ExtraBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 278 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
  • 🔥 FAIL

    Variable font instance name 'Noto Serif TC ExtraLight ExtraBold' formed by space-separated concatenation of font family name (nameID 1) and instance subfamily nameID 278 exceeds 32 characters.

This has been found to cause shaping issues for some accented letters in Microsoft Word on Windows 10 and 11.

[code: instance-too-long]
🔥 FAIL Check license file has good copyright string.
  • 🔥 FAIL

    First line in license file is:

"copyright 2012 google inc. all rights reserved."

which does not match the expected format, similar to:

"Copyright 2022 The Familyname Project Authors (git url)"

[code: bad-format]
🔥 FAIL Ensure dotted circle glyph is present and can attach marks.
  • 🔥 FAIL

    The following glyphs could not be attached to the dotted circle glyph:

- acutecomb

- gravecomb

- uni0307

- uni030C

[code: unattached-dotted-circle-marks]

🔥 FAIL Ensure files are not too large.
  • 🔥 FAIL

    Font file is 16.1Mb, larger than limit 9.0Mb


    [code: massive-font]
🔥 FAIL Copyright notices match canonical pattern in fonts
  • 🔥 FAIL

    Name Table entry: Copyright notices should match a pattern similar to:

"Copyright 2020 The Familyname Project Authors (git url)"

But instead we have got:

"(c) 2017-2024 Adobe (http://www.adobe.com/)."

[code: bad-notice-format]
  • 🔥 FAIL

    METADATA.pb: Copyright notices should match a pattern similar to:

"Copyright 2020 The Familyname Project Authors (git url)"

But instead we have got:

"(c) 2017-2024 Adobe (http://www.adobe.com/)."

[code: bad-notice-format]
⚠️ WARN Font has correct post table version?
  • ⚠️ WARN

    Post table format 3 use has niche use case problems.Please review the check rationale for additional details.


    [code: post-table-version]
⚠️ WARN Check mark characters are in GDEF mark glyph class.
  • ⚠️ WARN

    The following mark characters could be in the GDEF mark glyph class:
    uni0304 (U+0304), uni20DD (U+20DD), uni20DE (U+20DE), uni302A (U+302A), uni302B (U+302B), uni302C (U+302C), uni302D (U+302D), uni3099 (U+3099) and uni309A (U+309A)


    [code: mark-chars]
⚠️ WARN Detect any interpolation issues in the font.
  • ⚠️ WARN

    Interpolation issues were found in the font:

- Contour 2 point 15 in glyph 'uniFF7C' has a kink between location wght=200 and location wght=900

- Contour 1 point 17 in glyph 'uniFF9D' has a kink between location wght=200 and location wght=900

- Contour 19 in glyph 'uni56D3': becomes underweight between wght=200 and wght=900.

- Contour 10 in glyph 'uni5ABB': becomes underweight between wght=200 and wght=900.

- Contour 15 in glyph 'uni3B22': becomes underweight between wght=200 and wght=900.

[code: interpolation-issues]

⚠️ WARN Check math signs have the same width.
  • ⚠️ WARN

    The most common width is 1000 among a set of 43 math glyphs.
    The following math glyphs have a different width, though:

Width = 571: equal, less, plus, minus, greater, logicalnot

[code: width-outliers]
⚠️ WARN Does the font contain a soft hyphen?
  • ⚠️ WARN

    This font has a 'Soft Hyphen' character.


    [code: softhyphen]
⚠️ WARN Check font contains no unreachable glyphs
  • ⚠️ WARN

    The following glyphs could not be reached by codepoint or substitution rules:

- glyph00470

- glyph00472

- glyph00473

- glyph00477

- glyph00603

- glyph01006

- glyph01112

- glyph01134

- glyph01668

- glyph01670

- 96 more.

Use -F or --full-lists to disable shortening of long lists.

[code: unreachable-glyphs]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets.
  • ⚠️ WARN

    Article page lacks visual assets.


    [code: missing-visual-asset]
⚠️ WARN Check for codepoints not covered by METADATA subsets.
  • ⚠️ WARN

    The following codepoints supported by the font are not covered by
    any subsets defined in the font's metadata file, and will never
    be served. You can solve this by either manually adding additional
    subset declarations to METADATA.pb, or by editing the glyphset
    definitions.

  • U+02C7 CARON: try adding one of: tifinagh, yi, canadian-aboriginal
  • U+02C9 MODIFIER LETTER MACRON: not included in any glyphset definition
  • U+02CA MODIFIER LETTER ACUTE ACCENT: not included in any glyphset definition
  • U+02CB MODIFIER LETTER GRAVE ACCENT: not included in any glyphset definition
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02EA MODIFIER LETTER YIN DEPARTING TONE MARK: not included in any glyphset definition
  • U+02EB MODIFIER LETTER YANG DEPARTING TONE MARK: not included in any glyphset definition
  • U+0307 COMBINING DOT ABOVE: try adding one of: tifinagh, tai-le, canadian-aboriginal, syriac, old-permic, math, coptic, malayalam
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+0391 GREEK CAPITAL LETTER ALPHA: try adding one of: elbasan, math, greek 13915 more.

Use -F or --full-lists to disable shortening of long lists.

Or you can add the above codepoints to one of the subsets supported by the font: chinese-traditional, cyrillic, latin, latin-ext, menu, vietnamese

[code: unreachable-subsetting]
⚠️ WARN Check OFL body text is correct.

Lines changed:

- This Font Software is licensed under the SIL Open Font License, Version 1.1.\n

+ This Font Software is licensed under the SIL Open Font License,\n

+ Version 1.1.\n

+ \n

- \n

- development of collaborative font projects, to support the font creation\n

+ development of collaborative font projects, to support the font\n

- efforts of academic and linguistic communities, and to provide a free and\n

+ creation efforts of academic and linguistic communities, and to\n

- open framework in which fonts may be shared and improved in partnership\n

- with others.\n

+ provide a free and open framework in which fonts may be shared and\n

+ improved in partnership with others.\n

- requirement for fonts to remain under this license does not apply\n

+ requirement for fonts to remain under this license does not apply to\n

- to any document created using the fonts or their derivatives.\n

+ any document created using the fonts or their derivatives.\n

- "Original Version" refers to the collection of Font Software components as\n

+ "Original Version" refers to the collection of Font Software\n

- distributed by the Copyright Holder(s).\n

+ components as distributed by the Copyright Holder(s).\n

- "Modified Version" refers to any derivative made by adding to, deleting,\n

+ "Modified Version" refers to any derivative made by adding to,\n

- or substituting -- in part or in whole -- any of the components of the\n

+ deleting, or substituting -- in part or in whole -- any of the\n

- Original Version, by changing formats or by porting the Font Software to a\n

- new environment.\n

+ components of the Original Version, by changing formats or by porting\n

+ the Font Software to a new environment.\n

- a copy of the Font Software, to use, study, copy, merge, embed, modify,\n

+ a copy of the Font Software, to use, study, copy, merge, embed,\n

- redistribute, and sell modified and unmodified copies of the Font\n

+ modify, redistribute, and sell modified and unmodified copies of the\n

- Software, subject to the following conditions:\n

+ Font Software, subject to the following conditions:\n

- 1) Neither the Font Software nor any of its individual components,\n

+ 1) Neither the Font Software nor any of its individual components, in\n

- in Original or Modified Versions, may be sold by itself.\n

+ Original or Modified Versions, may be sold by itself.\n

- Name(s) unless explicit written permission is granted by the corresponding\n

+ Name(s) unless explicit written permission is granted by the\n

- Copyright Holder. This restriction only applies to the primary font name as\n

+ corresponding Copyright Holder. This restriction only applies to the\n

- presented to the users.\n

+ primary font name as presented to the users.\n

- remain under this license does not apply to any document created\n

+ remain under this license does not apply to any document created using\n

- using the Font Software.\n

+ the Font Software.\n

[code: incorrect-ofl-body-text]
⚠️ WARN Check the direction of the outermost contour in each glyph
  • ⚠️ WARN

    The following glyphs have a counter-clockwise outer contour:

* glyph18177 has a counter-clockwise outer contour

* glyph18179 has a counter-clockwise outer contour

* glyph20536 has a counter-clockwise outer contour

* glyph20608 has a counter-clockwise outer contour

* glyph20907 has a counter-clockwise outer contour

* glyph20908 has a counter-clockwise outer contour

* glyph20908 has a counter-clockwise outer contour

* quotedblleft (U+201C) has a counter-clockwise outer contour

* quotedblleft (U+201C) has a counter-clockwise outer contour

* quotedblright (U+201D) has a counter-clockwise outer contour

* 42 more.

Use -F or --full-lists to disable shortening of long lists.

[code: ccw-outer-contour]
⚠️ WARN Is there kerning info for non-ligated sequences?
  • ⚠️ WARN

    GPOS table lacks kerning info for the following non-ligated sequences:

- f + f

- f + i

- f + l

[code: lacks-kern-info]

⚠️ WARN Are there caret positions declared for every ligature?
  • ⚠️ WARN

    This font lacks caret position values for ligature glyphs on its GDEF table.


    [code: lacks-caret-pos]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table.
  • ⚠️ WARN

    This font file does not have a 'meta' table.


    [code: lacks-meta-table]
ℹ️ INFO List all superfamily filepaths
  • ℹ️ INFO

    ofl/notoseriftc


    [code: family-path]
ℹ️ INFO Font contains all required tables?
  • ℹ️ INFO

    This font contains the following optional tables:

- loca

- prep

- BASE

- GPOS

- GSUB

- gasp

- vhea

- vmtx

[code: optional-tables]

ℹ️ INFO METADATA.pb: Validate family.minisite_url field.
  • ℹ️ INFO

    Please consider adding a family.minisite_url entry.


    [code: lacks-minisite-url]
ℹ️ INFO EPAR table present in font?
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering?
  • ℹ️ INFO

    These are the ppm ranges declared on the gasp table:

PPM <= 65535: flag = 0x0F - Use grid-fitting - Use grayscale rendering - Use gridfitting with ClearType symmetric smoothing - Use smoothing along multiple axes with ClearType®

[code: ranges]
ℹ️ INFO Show hinting filesize impact.
  • ℹ️ INFO

    Hinting filesize impact:

ofl/notoseriftc/NotoSerifTC[wght].ttf
Dehinted Size 16.1Mb
Hinted Size 16.1Mb
Increase 24 bytes
Change 0.0 %
[code: size-impact]
ℹ️ INFO Font has old ttfautohint applied?
  • ℹ️ INFO

    Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: ['Version 2.003-H1;hotconv 1.1.1;makeotfexe 2.6.0']


    [code: version-not-detected]
[1] Family checks
ℹ️ INFO Check axis ordering on the STAT table.
  • ℹ️ INFO

    None of the fonts lack a STAT table.

And these are the most common STAT axis orderings:
('wght', 1)

[code: summary]

Summary

💥 ERROR ☠ FATAL 🔥 FAIL ⚠️ WARN ⏩ SKIP ℹ️ INFO ✅ PASS 🔎 DEBUG
0 0 9 13 51 8 170 0
0% 0% 4% 5% 20% 3% 68% 0%

Note: The following loglevels were omitted in this report:

  • SKIP
  • PASS
  • DEBUG

@punchcutter
Copy link

I'm not sure why U+4DB9 was in the TC subset in the first place. The main reason it's in at all is because GB18030-2022 added it to Level 2 and then later retracted that and moved it to Level 3. So before they moved it to Level 3 we updated Serif and unnecessarily added it to more than SC.

For the others I missed updating the ReadMe...

These three are from adobe-fonts/source-han-serif#155 C3, C4, C5
U+615D 慝 now takes the simplified form
U+7661 癡 now takes Japanese/traditional form
U+88CA 裊 bottom left of bird radical has changed, again looks like an improvement

This one is from adobe-fonts/source-han-serif#138
U+22ACF 𢫏 got a redesign, but it looks an improvement to my eyes

@simoncozens simoncozens linked an issue Aug 20, 2024 that may be closed by this pull request
Update Noto Serif CJK to v2.003 #7998
Closed
@vv-monsalve vv-monsalve added the II CJK Chinese, Japanese, Korean scripts label Aug 20, 2024
@vv-monsalve
Copy link
Collaborator

Thank you for the detailed list of key changes. Everything seems to match the reported modified glyphs.

Noto-Serif-TC

@vv-monsalve vv-monsalve merged commit 3f22720 into main Aug 20, 2024
5 checks passed
@vv-monsalve vv-monsalve deleted the gftools_packager_ofl_notoseriftc branch August 20, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vv-monsalve vv-monsalve vv-monsalve approved these changes

Assignees
No one assigned
Labels
I Font Upgrade II CJK Chinese, Japanese, Korean scripts
Projects
Fonts Traffic Jam
Status: Live
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Noto Serif CJK to v2.003
3 participants
@simoncozens @punchcutter @vv-monsalve