-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flax.nnx.value_and_grad
docstring
#4372
Open
8bitmp3
wants to merge
2
commits into
google:main
Choose a base branch
from
8bitmp3:add-nnx-value_and_grad-docstring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
reviewed
Nov 12, 2024
cgarciae
approved these changes
Nov 12, 2024
8bitmp3
commented
Nov 12, 2024
8bitmp3
force-pushed
the
add-nnx-value_and_grad-docstring
branch
from
November 13, 2024 22:42
60abeb4
to
c4264ee
Compare
@8bitmp3 some tests are failing. |
Found it.
|
8bitmp3
force-pushed
the
add-nnx-value_and_grad-docstring
branch
from
November 15, 2024 16:09
c4264ee
to
26499a7
Compare
@8bitmp3 CI is still failing |
The error:
I could try without |
@8bitmp3 copy the output you see there and paste it on the example e.g:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cgarciae @IvyZX @levskaya