Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Flax NNX Randomness #4279

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

8bitmp3
Copy link
Collaborator

@8bitmp3 8bitmp3 commented Oct 10, 2024

@8bitmp3 8bitmp3 requested review from cgarciae and IvyZX October 10, 2024 00:01
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@8bitmp3 8bitmp3 force-pushed the update-nnx-randomness branch from 88d53d9 to 0823b16 Compare October 10, 2024 12:15
@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 10, 2024

Also updating:

- Here is a list of the main PRNG-related types in Flax NNX:
+ Here are the main PRNG-related types in Flax NNX:

Added the JAX jax.random tutorial for new users:

> **Note:** To learn more about random number generation in JAX,
the `jax.random` API, and PRNG-generated sequences, check out
this [JAX PRNG tutorial](https://jax.readthedocs.io/en/latest/random-numbers.html).

Added a link to JAX Working with pytrees for new users:

`nnx.reseed` is a function that accepts an arbitrary graph node (this includes
[pytrees](https://jax.readthedocs.io/en/latest/working-with-pytrees.html#working-with-pytrees)
of `nnx.Module`s)...

Added nnx.:

...`nnx.Rngs` object..... `nnx.reseed`.... `nnx.Dropout`

@8bitmp3 8bitmp3 self-assigned this Oct 10, 2024
@8bitmp3 8bitmp3 force-pushed the update-nnx-randomness branch from 0823b16 to 363e8ab Compare October 10, 2024 21:38
@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 10, 2024

rebasing after #4281

@8bitmp3 8bitmp3 closed this Oct 10, 2024
@8bitmp3 8bitmp3 force-pushed the update-nnx-randomness branch from 4ab4cfc to 11f3616 Compare October 10, 2024 21:48
@8bitmp3 8bitmp3 reopened this Oct 10, 2024
@8bitmp3 8bitmp3 force-pushed the update-nnx-randomness branch from 57f8d34 to 3798306 Compare October 10, 2024 22:47
@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 15, 2024

@cgarciae PTAL, thanks!

docs_nnx/guides/randomness.ipynb Outdated Show resolved Hide resolved
@8bitmp3 8bitmp3 force-pushed the update-nnx-randomness branch from 3798306 to cc9b77c Compare November 29, 2024 19:12
@8bitmp3 8bitmp3 force-pushed the update-nnx-randomness branch from cc9b77c to f16e6d6 Compare November 29, 2024 19:40
@copybara-service copybara-service bot merged commit a5e62af into google:main Dec 1, 2024
17 checks passed
@8bitmp3 8bitmp3 deleted the update-nnx-randomness branch December 2, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants