[Go] Write required string fields into the buffer when using Object API #8402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C++, CreateX allows to write the default "" value of a required string, when the string is not explicitly set. Object API Pack method uses this implementation of CreateX. However, in go, despite whether the field is optional or required, it is always checked against empty string allowing to create messages that fail to pass the verifier. This commits partially reverts google#7719 when the string field is required.
The Monster schema contains a key string field. For historical convenience reasons, string keys are assumed required.
github-actions
bot
added
c++
codegen
razvanalex
force-pushed
the
go-object-api
branch
from
0444c4e to
991dd52
Compare
|
This pull request is stale because it has been open 6 months with no activity. Please comment or label |
|
It is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C++, CreateX allows to write the default "" value of a required string, when the string is not explicitly set (i.e., here). Object API Pack method uses this implementation of CreateX.
However, in go, despite whether the field is optional or required, it is always checked against empty string allowing to create messages that fail to pass the verifier. This commit partially reverts #7719 when the string field is required. It also affects string fields marked as key, which are considered required (i.e., here).