Skip to content

Conversation

bjornharrtell
Copy link
Collaborator

ref #8293

@bjornharrtell
Copy link
Collaborator Author

@ccorsano would you be willing to try this out in your scenario with .NET Source Generators?

@ccorsano
Copy link

@bjornharrtell I got your changes and was able to integrate the library with my source generator test project, it looks good to me.

My little experiment then fell short as my idea required file IO (to generate a bfbs schema then parse it), which, as I now learned is heavily discouraged (to not say forbidden) in source generators.

That being said, the alternative way of achieving my current goal is to write a custom MSBuild task, which has the same constraint of requiring netstandard2.0 (due to Visual Studio still running .Net Framework internally).

Overall netstandard2.0 is the last bridge to .Net Framework, so I still think it is a valuable target to keep.

@bjornharrtell
Copy link
Collaborator Author

Hmm.. a bridge to .NET Framework is something else which I'm not to keen on myself.

@pavan709
Copy link

@bjornharrtell as UWP still uses the .netstandard 2.0, i am unable to install this.

@bjornharrtell
Copy link
Collaborator Author

@pavan709 assuming you mean you can't use flatbuffers without this change.

@bjornharrtell
Copy link
Collaborator Author

@dbaileychess are you willing to accept this?

@pavan709
Copy link

yes @bjornharrtell without the support of .netstandard 2.0 it is not possible to install the flatbuffer in UWP, and UWP is widely used framework, .netstandard is not only a bridge to .net framework, rather .netstandard apis are used across the .net implementaions.

@bjornharrtell
Copy link
Collaborator Author

@pavan709 I'm aware of . net standard versions, but I was not aware of UWP. Anyway I support merge of this just need review to get in.

@dbaileychess dbaileychess merged commit ef30729 into google:master May 29, 2024
@bjornharrtell bjornharrtell deleted the issue-8293 branch May 29, 2024 05:06
@njannink
Copy link

njannink commented Jul 1, 2024

Any eta on a release?

jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants