[dart] fix bug which generated wrong code #8259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fawdlstty
force-pushed
the
fix_dart_gen_wrong
branch
from
e787914 to
e7040f8
Compare
|
Thanks a lot! Can you maybe add a test schema to dart directory and regenerate with the new flatc? You just need to compile flatc and run test/DartTest.sh That way this won't regress in the future unnoticed. |
|
This pull request is stale because it has been open 6 months with no activity. Please comment or label |
|
This pull request was automatically closed due to no activity for 6 months plus the 14 day notice period. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7609