-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[Rust] Add the Allocator trait for the builder API #8106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe this change is semver compatible but do let me know if you see a place where this is not the case. The only open question I have is whether the |
984b0fd
to
43eb1e5
Compare
Nice! Thank you for the PR |
e80fb71
to
de9c6b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some nitpicks
de9c6b2
to
0e297db
Compare
0e297db
to
dbe5bc6
Compare
This commit is just backporting the change that got merged upstream: google/flatbuffers#8106 Change-Id: I7b7c7b507f8f2efc0213868d9911c8009274fd6e Signed-off-by: James Kuszmaul <[email protected]>
* Add an Allocator trait for FlatBufferBuilder * Update rust generated code
* Add an Allocator trait for FlatBufferBuilder * Update rust generated code
This PR adds the Allocator trait that is now used in FlatBufferBuilder. Fixes #7385