Skip to content

Conversation

adsnaider
Copy link
Contributor

This PR adds the Allocator trait that is now used in FlatBufferBuilder. Fixes #7385

@github-actions github-actions bot added c++ rust codegen Involving generating code from schema labels Oct 5, 2023
@adsnaider
Copy link
Contributor Author

I believe this change is semver compatible but do let me know if you see a place where this is not the case. The only open question I have is whether the trait Allocator should actually be unsafe trait Allocator. I'm not familiar enough with the internals to answer that.

@CasperN
Copy link
Collaborator

CasperN commented Oct 5, 2023

Nice! Thank you for the PR

@adsnaider adsnaider force-pushed the allocator_trait branch 2 times, most recently from e80fb71 to de9c6b2 Compare October 5, 2023 22:23
CasperN
CasperN previously approved these changes Oct 6, 2023
Copy link
Collaborator

@CasperN CasperN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some nitpicks

@CasperN CasperN enabled auto-merge (squash) October 7, 2023 19:20
@CasperN CasperN merged commit 205285c into google:master Oct 7, 2023
frc971-automation pushed a commit to frc971/971-Robot-Code that referenced this pull request Feb 19, 2024
This commit is just backporting the change that got merged
upstream: google/flatbuffers#8106

Change-Id: I7b7c7b507f8f2efc0213868d9911c8009274fd6e
Signed-off-by: James Kuszmaul <[email protected]>
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Add an Allocator trait for FlatBufferBuilder

* Update rust generated code
jochenparm pushed a commit to jochenparm/flatbuffers that referenced this pull request Oct 29, 2024
* Add an Allocator trait for FlatBufferBuilder

* Update rust generated code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ codegen Involving generating code from schema rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rust] Proposal for non-owning FlatBufferBuilder API
3 participants